fix: Add aria-label to read the day of the week instead of the shorthand #4693
Conversation
|
Can you make sure to add a test for this change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4693 +/- ##
==========================================
+ Coverage 97.00% 97.09% +0.08%
==========================================
Files 28 28
Lines 2641 2653 +12
Branches 1119 1123 +4
==========================================
+ Hits 2562 2576 +14
+ Misses 79 77 -2 ☔ View full report in Codecov by Sentry. |
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@plahteenlahti you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
This is a great improvement for a subtle detail and looks good to me. Thanks for catching this and fixing it!
Reviewed with ❤️ by PullRequest
Description
Linked issue: #3185
Problem
When using a screenreader it reads the days in the header as "Mo", "Tu"... etc. instead of the more understandable full name See the linked issue for a more detailed description
Changes
This PR adds aria-labels to the header dates so that the screenreader now reads days with full name e.g. "Monday" instead of "Mo"
Contribution checklist